fix duplication accuracy level calculations logic bug #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I made two fixes to the duplicate calculation:
Fix Bloom membership logic: use AND across all hashes
isDup &= (ret & byte) != 0;instead of overwriting isDup each iterationisDup = (ret & byte) != 0;. The old behavior effectively depended only on the last hash, which could lead to incorrect duplicate results. I have saw this error in my RNA-seq data analysis result.Fix non–power-of-two masking at accuracy level 6: at level 6,
mBufNum=6andPRIME_ARRAY_LEN * mBufNumis not a power of two, sooffset &= maskis not equivalent to modulo and causes biased indexing. I changed level 6 to usemBufNum=8(mBufNum *= 4), makingPRIME_ARRAY_LEN * mBufNuma power of two so the existing offset &= mask logic is correct.